feat!: update Sentry SDK from v6 to v7 #461
Conversation
|
@rchl could you pls look into reviewing this PR? It's quite important for our project to get sentry to v7. I'm happy to take care of any changes necessary... I run the tests locally and they passed and also tried to link it to our project and reported mock errors from there. I went through the docs and tried to spot any reference that needs to be updated. |
|
Hmm, I missed some parts in the options.js file still using sentry/browser - will fix that |
LukasHirt
force-pushed
the
feat/migrate-to-sentry-7
branch
from
74c1da4
to
0d6b0a5
Compare
|
@rchl ok, now it should be ready for review |
|
I suppose this requires new major version of the module and adding migration guide (like https://i18n.nuxtjs.org/migrating). Also there is a question of whether this should have its own major version and then #456 should trigger yet another major version or whether those two changes should be sharing same, new major version (thus requiring nuxt/kit and potentially causing extra issues for Nuxt 2 users...). |
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 69.23% 69.23%
=======================================
Files 1 1
Lines 52 52
Branches 21 21
=======================================
Hits 36 36
Misses 13 13
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Does #456 for Nuxt 2 require a dependency on If possible, and if they can be done seperately, I would prefer two seperate majors with the upgrade to Sentry 7 before the #456. This means existing users can upgrade, without having to move to either
|
|
Yes, i agree with that given that migration to bridge can prove problematic |
* main: chore: release 6.0.2 fix(tracing): merge user's tracing configuration (nuxt-community#463)
|
@rchl thanks for your review and your commits! I'll try to get this week the time to look into this again. |
|
I've picked up some work on this module and created various commits on master that can conflict with this task. I can help with merging and resolving conflicts. |
* main: fix(tracing): autoSessionTracking not working on the server-side (nuxt-community#466) fix: incorrect option name in the warning message (nuxt-community#467) chore(deps): don't update node version chore(deps): enable lock file maintenance for docs chore(docs): add .nvmrc for netlify and local dev chore(docs): update all sub-dependencies chore(docs): always build fix(deps): update devdependency @sentry/webpack-plugin to ^1.20.0 (nuxt-community#451) chore(deps): update all non-major dependencies (nuxt-community#449) chore(docs): fix documentation deploying, maybe
|
Apart from tweaking the docs, I'm pretty happy with the changes and ready to merge when you are. I will still likely do some follow up changes to enable router integration and support tracing in |
* main: fix: gracefully handle Nuxt versions without Runtime Config (nuxt-community#472)
rchl
changed the title
|
Thanks! |
* fix/tree-shake: feat: enable tree shaking of Sentry SDK debug code chore(lint): enable linting for more files within the repo chore(deps): update lock file fix(deps): update sentry dependencies to ^7.28.0 (#478) docs: minor updates about dependencies and lazy+tracing feat: support plugin path for clientConfig and serverConfig (#477) feat(tracing): enable Vue Router instrumentation by default (#476) Revert "feat(tracing): enable Vue Router instrumentation by default" feat(tracing): enable Vue Router instrumentation by default chore(lint): tweak eslint ignore directives for generated plugin files chore(deps): update devdependency sentry-testkit to v5 chore(deps): update devdependency @nuxtjs/eslint-config-typescript to v12 chore(deps): update sentry dependencies to ^7.27.0 (#474) feat!: update Sentry SDK from v6 to v7 (#461) docs: add information about enriching events (#473) fix: gracefully handle Nuxt versions without Runtime Config (#472)
Summary
Related issues