Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency defu to v6.1.3 #607

Merged
merged 2 commits into from Oct 31, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
defu 6.1.2 -> 6.1.3 age adoption passing confidence

Release Notes

unjs/defu (defu)

v6.1.3

Compare Source

compare changes

🩹 Fixes
  • Only merge plain objects (#​111)
📖 Documentation
📦 Build
  • Backward compatible cjs entry (#​110)
🏡 Chore
🎨 Styles
  • Format with prettier v3 (32650f1)
❤️ Contributors

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

size-limit report 📦

Path Size
fixture: base 381.53 KB (0%)
fixture: lazy 386.28 KB (0%)
fixture: tracing 401.72 KB (0%)
fixture: lazy+tracing 406.43 KB (0%)

@renovate renovate bot changed the title chore(deps): update devdependency eslint to v8.47.0 chore(deps): update all non-major dependencies Aug 13, 2023
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 5 times, most recently from f648e14 to 02d7f8a Compare August 19, 2023 01:15
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 11 times, most recently from 95dd789 to 932e904 Compare August 28, 2023 09:12
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 6 times, most recently from 07f6842 to 151bb49 Compare September 4, 2023 16:08
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 5 times, most recently from b2aded1 to 98bd621 Compare September 15, 2023 10:08
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 7 times, most recently from 7b3b24b to 3a9e5ad Compare October 12, 2023 00:46
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 7 times, most recently from 3aa02f1 to 23bd0cb Compare October 24, 2023 08:17
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 7 times, most recently from d62d779 to f6bd261 Compare October 31, 2023 18:18
@renovate renovate bot changed the title chore(deps): update all non-major dependencies chore(deps): update dependency defu to v6.1.3 Oct 31, 2023
@rchl
Copy link
Member

rchl commented Oct 31, 2023

@pi0 I suppose "Only merge plain objects (#​111)" is considered a bugfix but maybe you are interested in knowing that it breaks testing here.

The code is roughly:

const config = await import(`${dir}/fixture/${fixture ? fixture + '/' : ''}nuxt.config.cjs`)

const result = defu(override, config)

and those are logged objects:

  override: {
    sentry: {
      dsn: 'http://acacaeaccacacacabcaacdacdacadaca@localhost:58160/000001'
    }
  },
  config: [Object: null prototype] [Module] {
    rootDir: [Getter],
    telemetry: [Getter],
    dev: [Getter],
    render: [Getter],
    modules: [Getter],
    sentry: [Getter],
    publicRuntimeConfig: [Getter],
    default: {
      rootDir: '/usr/local/workspace/nuxt/sentry-module/test/fixture/lazy',
      telemetry: false,
      dev: false,
      render: [Object],
      modules: [Array],
      sentry: [Object],
      publicRuntimeConfig: [Object]
    }
  },
  result: {
    sentry: {
      dsn: 'http://acacaeaccacacacabcaacdacdacadaca@localhost:58160/000001'
    }
  }

So the object returned from async import is strangely not a POD and it fails. Not sure if that's normal for async import or it's because of running within jest but I guess it's an interesting case where this bug fix is a breaking change.

@rchl
Copy link
Member

rchl commented Oct 31, 2023

I'm adding a workaround for this but I wonder whether this apparent fix should be adjusted to work in this case...

I'm gonna do:

  // Returned object has "Module" type which defu ignores because it's not plain object.
  // Copy properties to the new object so that the object is not ignored.
  const config = Object.assign({}, await import(`${dir}/fixture/${fixture ? fixture + '/' : ''}nuxt.config.cjs`))

@rchl rchl merged commit b7a6df7 into main Oct 31, 2023
6 checks passed
@rchl rchl deleted the renovate/all-minor-patch branch October 31, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant