feat: add theme color support #2 #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mode-module into iamahuman-feat/theme-color
✅ Live Preview ready!
|
❌ Deploy Preview for nuxt-color-mode failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #121
Resolved all conflicts, some code refactoring and fixed a bug generated by the minify process, which made the feature unusable in production.
Debugging it was somewhat hard, because the dev playground doesn't use the production minified version of
script.ts. It uses a symbolic link to it. Thus, using the production build in my personal blog resulted in a different interpretation of the JSON lodash literal compared to the one in the dev environment. Managed to solve it by forcing esbuild to keep the backticks.Other changes: Added a
// @ts-nocheckat the top ofscript.tsto get rid of a lot of type error lines in the code. Not a good solution given it should be a real Typescript file. Nonetheless, proper minifying the file while running the playground is out of the scope of this feature.For now, it seems the feature works just fine. Tested in
SSR: trueandSSR: false. 🤗