fix: v-t directive SSR
#2946
Open
fix: v-t directive SSR
#2946
+49
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
reviewed
May 11, 2024
| */ | ||
|
|
||
| // Use `legacy` as global injections are prefixed (`$t`) | ||
| const transformVT = transformVTDirective({ mode: 'legacy' }) |
There was a problem hiding this comment.
I think mode option should be set from i18n.types
There was a problem hiding this comment.
Maybe I'm misunderstanding, but the injected component properties are always prefixed with $ (such as $t()) right?
When passing mode: 'composition' to the transform it will (in this case incorrectly) transform the code to use t() without prefix, which I think won't work 🤔.
kazupon
requested changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Resolves kazupon/kazupon#17
I thought adding the directive transformation would have been more involved than this but it seems to be working 😅
I'll see if I can update https://github.com/intlify/vue-i18n-extensions a bit and perhaps experiment with making something like intlify/vue-i18n#1820 possible, though to be honest, I'm not sure if that feature is the right direction but it would be good learning experience.
📝 Checklist