Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use module-builder stub mode for more accurate types #490

Merged
merged 5 commits into from Jan 9, 2024

Conversation

danielroe
Copy link
Collaborator

We added a prepare command for nuxt-module-build which allows creating type stubs directly from the module without needing to apply to the playground as well. (nuxt/module-builder#124)

It's the default for new modules (nuxt/starter#392).

This should allow us to match types more appropriately for module authors (for example, disallowing auto-imports) in future.

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit 30671f8
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/659d1e13d8f72b00083375ec

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59c0790) 57.04% compared to head (30671f8) 57.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   57.04%   57.12%   +0.07%     
==========================================
  Files          11       11              
  Lines         724      723       -1     
  Branches       32       32              
==========================================
  Hits          413      413              
+ Misses        311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe merged commit 486dc7c into main Jan 9, 2024
8 checks passed
@danielroe danielroe deleted the module-stub branch January 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant