feat: migrate to shikiji
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnabaz
reviewed
Sep 7, 2023
|
Looks perfect, only one thing seems missing in shikiji. I think this feature should implement in shikiji. |
|
Oh yeah, it was in my backlog, I will check |
antfu
commented
Sep 7, 2023
| .filter(color => color !== 'default') | ||
| .map(color => [ | ||
| `html.${color} .shiki,`, | ||
| `html.${color} .shiki span {`, |
There was a problem hiding this comment.
I am not sure if we should make this tiggering class configureable
There was a problem hiding this comment.
We had this for a long time, let's keep it and will might drop it in a major version.(otherwise we will introduce breaking change in content)
|
Ok, font-style fixed |
farnabaz
approved these changes
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #25
Migrating to
shikijiprovides a few benefits.shikijiuseshastinternally, so we can get rid of the conversation codeshikijihas multiple themes supported built-in (actually very similar to what we have here!), allowing us to reduce the complexitymdcgrammarThis might be a minor breaking change to the internal types and structure, but it shouldn't affect end users' code base.