Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using tw default config #636

Merged
merged 2 commits into from
Mar 21, 2023
Merged

chore: using tw default config #636

merged 2 commits into from
Mar 21, 2023

Conversation

ineshbose
Copy link
Collaborator

Reduces one file to maintain in the repo. However, tailwindcss/stubs/simpleConfig.stub maybe more what the original config was looking for, but importing it seems to be an issue with pnpm (and typescript) - I'm open to suggestions.

@what-the-diff
Copy link

what-the-diff bot commented Mar 16, 2023

  • The defaultTailwindConfig was changed from a function to an object.
  • tailwindcss/stubs/simpleConfig.stub is now imported instead of src/tailwind.config

@Atinux
Copy link
Collaborator

Atinux commented Mar 21, 2023

Open to get @manniL opinion on this

@manniL
Copy link
Contributor

manniL commented Mar 21, 2023

Makes sense to me as it resembles the current config pretty accurately, so won't introduce a breaking change. ☺️

@Atinux Atinux merged commit b89aa05 into nuxt-modules:main Mar 21, 2023
Atinux added a commit that referenced this pull request Mar 21, 2023
danielroe added a commit that referenced this pull request Mar 21, 2023
Atinux pushed a commit that referenced this pull request Mar 21, 2023
* chore: add missing deps

* Revert "Revert "chore: using tw default config (#636)""

This reverts commit 83ecb44.

* fix: use file extension (for esm support)

* fix: use tailwind stub

Co-authored-by: Inesh Bose <56732164+ineshbose@users.noreply.github.com>

---------

Co-authored-by: Inesh Bose <56732164+ineshbose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants