Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load secret from storage at runtime #297

Open
dargmuesli opened this issue Jan 25, 2024 · 0 comments 路 May be fixed by #298
Open

feat: load secret from storage at runtime #297

dargmuesli opened this issue Jan 25, 2024 · 0 comments 路 May be fixed by #298
Labels
enhancement New feature or request

Comments

@dargmuesli
Copy link
Collaborator

dargmuesli commented Jan 25, 2024

馃啋 Your use case

It's common to have secrets available as a file or similar when deploying a service (as explained in #174 (comment)). I'd like to be able to source the Turnstile secret key from such a file in production.

馃啎 The solution you'd like

In #174 we added secret sourcing to the module code, which runs at build time. I now noticed that secret sourcing doesn't work at runtime, at which it makes most sense. It would be beneficial if the secret key could be sourced in the Nitro verify util (instead).

馃攳 Alternatives you've considered

Warn for no secret key when building for production: #296

鈩癸笍 Additional info

cc @danielroe

Also, should we continue to just use node:fs when a secret key path is given or could we make use of something like unstorage maybe? Don't know if I understand that tool correctly.

@dargmuesli dargmuesli added the enhancement New feature or request label Jan 25, 2024
dargmuesli added a commit to dargmuesli/turnstile that referenced this issue Jan 25, 2024
@dargmuesli dargmuesli linked a pull request Jan 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant