Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): source at runtime #298

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dargmuesli
Copy link
Collaborator

@dargmuesli dargmuesli commented Jan 25, 2024

Resolves #297

Quick draft to demonstrate what I intend to achieve. Collaboration welcome.

Currently, there is no warning when building a project for production and no secret key is set.
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c564106) 19.26% compared to head (eaca0dc) 19.43%.

Files Patch % Lines
src/runtime/nitro/utils/verify.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   19.26%   19.43%   +0.16%     
==========================================
  Files          12       12              
  Lines         493      494       +1     
  Branches       23       21       -2     
==========================================
+ Hits           95       96       +1     
  Misses        398      398              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should read file system at runtime - this wouldn't work in non-Node environments, for example. Is there a situation where defining the secret key in an environment variable wouldn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: load secret from storage at runtime
2 participants