Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(component): remove nextTick #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dargmuesli
Copy link
Collaborator

Both mentioned issues are resolved now.

Both mentioned issues are resolved now.
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c564106) 19.26% compared to head (8aa2a4d) 19.34%.

Files Patch % Lines
src/runtime/components/NuxtTurnstile.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   19.26%   19.34%   +0.07%     
==========================================
  Files          12       12              
  Lines         493      491       -2     
  Branches       23       23              
==========================================
  Hits           95       95              
+ Misses        398      396       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe
Copy link
Collaborator

Nice! Have you confirmed that client-side navigation to a page with the Turnstile component still works?

@dargmuesli
Copy link
Collaborator Author

Yes, to the best of my knowledge: I enabled the playground widgets to load right away, navigated to /home and back and I noticed no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants