feat: nuxt-scripts integration #306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huang-julien
commented
Apr 8, 2024
harlan-zw
reviewed
Apr 12, 2024
harlan-zw
reviewed
Apr 12, 2024
harlan-zw
reviewed
Apr 12, 2024
harlan-zw
reviewed
Apr 12, 2024
harlan-zw
reviewed
Apr 12, 2024
harlan-zw
reviewed
Apr 12, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
30
to
+35
| urls | ||
| .map(url => url.toString()) | ||
| .includes( | ||
| 'https://challenges.cloudflare.com/turnstile/v0/api.js?onload=onloadTurnstileCallback', | ||
| ), | ||
| // look for the challenge platform iframe | ||
| 'https://challenges.cloudflare.com/cdn-cgi/challenge-platform' | ||
| ) |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
50 tasks
harlan-zw
reviewed
May 6, 2024
|
|
||
| import { nextTick, useScriptCloudflareTurnstile, useRuntimeConfig, useNuxtApp, ref, onMounted, onBeforeUnmount } from '#imports' | ||
|
|
||
| const props = defineProps({ |
There was a problem hiding this comment.
We want to expose a trigger option to allow users granular access of when the script loads, see https://github.com/nuxt/scripts/blob/main/src/runtime/components/ScriptGoogleMaps.vue#L44
This was referenced May 6, 2024
Comment on lines
31
to
+35
| .map(url => url.toString()) | ||
| .includes( | ||
| 'https://challenges.cloudflare.com/turnstile/v0/api.js?onload=onloadTurnstileCallback', | ||
| ), | ||
| // look for the challenge platform iframe | ||
| 'https://challenges.cloudflare.com/cdn-cgi/challenge-platform' | ||
| ) |
There was a problem hiding this comment.
I would assume converting these to URL objects would help?
url.map(url=>new URL(url.toString())).some(url=>url.hostname === 'challenges.cloudflare.com' && url.pathname === '/cdn-cgi/challenge-platform')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This PR implements
@nuxt/scriptsfornuxt >= 3.11.1(we'll see if we remove the compatibility field in@nuxt/scripts)