Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overflow social icons in AppHeaderDialog #803

Merged
merged 1 commit into from Feb 1, 2023
Merged

fix: overflow social icons in AppHeaderDialog #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/app/AppHeader.vue
View file
Open in desktop
Expand Up @@ -80,7 +80,11 @@ css({
alignItems: 'center',
flex: 'none',
'&.left': {
gridColumn: 'span 4 / span 4'
gridColumn: 'span 4 / span 4',
marginLeft: 'calc(0px - {space.4})',
'@lg': {
marginLeft: 0
},
},
'&.center': {
gridColumn: 'span 4 / span 4',
Expand Down
15 changes: 9 additions & 6 deletions components/app/AppHeaderDialog.vue
View file
Open in desktop
@@ -1,6 +1,4 @@
<script setup lang="ts">
import ThemeSelect from './ThemeSelect.vue'
const { navigation } = useContent()
const { config } = useDocus()
Expand All @@ -27,13 +25,12 @@ watch(visible, v => (v ? open() : close()))
<teleport to="body">
<nav v-if="visible" class="dialog" @click="close">
<div @click.stop>
<div>
<div class="wrapper">
<button aria-label="Menu" @click="close">
<Icon name="heroicons-outline:x" aria-hidden="”true”" />
</button>

<div class="icons">
<ThemeSelect />
<AppSocialIcons />
</div>
</div>
Expand All @@ -49,7 +46,8 @@ css({
button: {
position: 'relative',
zIndex: '10',
borderRadius: '{radii.xl}',
display: 'flex',
padding: '{space.4}',
'@lg': {
display: 'none'
},
Expand Down Expand Up @@ -79,6 +77,12 @@ css({
'@lg': {
display: 'none'
},
'.wrapper': {
marginLeft: 'calc(0px - {space.4})',
},
'.icons': {
overflow: 'auto'
},
// Dialog content
'& > div': {
maxWidth: '{size.xs}',
Expand All @@ -104,7 +108,6 @@ css({
'.icons': {
display: 'flex',
alignItems: 'center',
gap: '{space.4}'
}
}
}
Expand Down