Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove empty directory span #822

Merged
merged 2 commits into from Feb 20, 2023
Merged

fix: remove empty directory span #822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e907a1
fix: remove empty directory span
bdrtsky Feb 16, 2023
808bf9e
fix: remove casting
bdrtsky Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/docs/DocsPrevNext.vue
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ const directory = (link: any) => {
>
<Icon name="heroicons-outline:arrow-sm-left" class="icon" />
<div class="wrapper">
<span class="directory">
<span v-if="!!directory(prev._path)" class="directory">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not:

Suggested change
<span v-if="!!directory(prev._path)" class="directory">
<span v-if="directory(prev._path)" class="directory">

{{ directory(prev._path) }}
</span>
<span class="title">{{ prev.title }}</span>
Expand All @@ -41,7 +41,7 @@ const directory = (link: any) => {
class="next"
>
<div class="wrapper">
<span class="directory">
<span v-if="!!directory(next._path)" class="directory">
bdrtsky marked this conversation as resolved.
Show resolved Hide resolved
{{ directory(next._path) }}
</span>
<span class="title">{{ next.title }}</span>
Expand Down