Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DocsPageLayout aside/ToC grid #828

Merged
merged 1 commit into from Feb 22, 2023
Merged

fix: DocsPageLayout aside/ToC grid #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 22 additions & 12 deletions components/docs/DocsPageLayout.vue
View file
Open in desktop
Expand Up @@ -59,6 +59,8 @@ onBeforeUnmount(() => {
class="docs-page-content"
:class="{
fluid: config?.main?.fluid,
'has-toc': hasToc,
'has-aside': hasAside,
}"
>
<!-- Aside -->
Expand All @@ -67,12 +69,7 @@ onBeforeUnmount(() => {
</aside>

<!-- Page Body -->
<article
class="page-body"
:class="{
'with-toc': hasToc,
}"
>
<article class="page-body">
<slot v-if="hasBody" />
<Alert v-else type="info">
Start writing in <ProseCodeInline>content/{{ page._file }}</ProseCodeInline> to see this page taking shape.
Expand Down Expand Up @@ -108,9 +105,22 @@ css({
'@lg': {
display: 'grid',
gap: '{space.8}',
// gridTemplateColumns: 'repeat(12, minmax(0, 1fr))'
gridTemplateColumns: 'minmax(250px, 250px) minmax(320px, 1fr) minmax(250px, 250px)'
}
},
'&.has-toc': {
'@lg': {
gridTemplateColumns: 'minmax(320px, 1fr) minmax(250px, 250px)'
}
},
'&.has-aside': {
'@lg': {
gridTemplateColumns: 'minmax(250px, 250px) minmax(320px, 1fr)'
}
},
'&.has-aside.has-toc': {
'@lg': {
gridTemplateColumns: 'minmax(250px, 250px) minmax(320px, 1fr) minmax(250px, 250px)'
}
},
},
'.aside-nav': {
display: 'none',
Expand All @@ -136,17 +146,17 @@ css({
flex: '1 1 0%',
py: '{space.8}',
width: '100%',
maxWidth: '{docus.readableLine}',
// maxWidth: '{docus.readableLine}',
mx: 'auto',
'&.with-toc': {
'.has-toc &&': {
paddingTop: '{space.12}',
'@lg': {
paddingTop: '{space.8}',
}
},
'@lg': {
marginTop: 0,
gridColumnStart: 2,
// gridColumnStart: 2,
},
// `.not-prose` can be useful if creating <h1> with a component (404 page is an example)
':deep(h1:not(.not-prose):first-child)': {
Expand Down