Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): extend logo types #920

Merged
merged 1 commit into from Jun 30, 2023
Merged

fix(schema): extend logo types #920

merged 1 commit into from Jun 30, 2023

Conversation

owlnai
Copy link
Contributor

@owlnai owlnai commented Jun 9, 2023

Based on AppHeaderLogo.vue, you can set either a boolean, string or object for the logo.

Currently, the generated type is only boolean, which breaks the type checking if you want to set a component (string) or the dark/light logo image URLs (object with strings).

This PR fixes this by setting the appropiate types. I have tested in the playground and works as expected.

NOTE: I'm not sure what to do with studioInput. Does it break in Studio if you don't use a boolean?

@Atinux Atinux merged commit eac38fe into nuxt-themes:main Jun 30, 2023
@Atinux
Copy link
Contributor

Atinux commented Jun 30, 2023

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants