Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore vue2-compat alias and de-default export #398

Closed
wants to merge 2 commits into from

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #393

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The Vue CJS build does not have named exports, but all functions are present on the default export. This adds some complexity for the webpack build. We can work around this by adding back the vue compat plugin and de-defaulting the Vue import.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 10, 2022
@danielroe danielroe requested a review from antfu July 10, 2022 09:44
@danielroe danielroe self-assigned this Jul 10, 2022
@danielroe danielroe marked this pull request as draft July 12, 2022 09:42
@danielroe danielroe closed this Jul 20, 2022
@danielroe danielroe deleted the fix/vue-aliases branch July 20, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"export 'onBeforeUnmount' was not found in 'vue' and missing .output
1 participant