Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dev): rewrite to support --no-fork and improve stability #153

Merged
merged 4 commits into from Sep 7, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 7, 2023

This PR applies relatively large amounts of refactoring to the dev command:

  • Extract base nuxt dev server logic to shared util
  • Support --no-fork mode without spawning a new process
  • Improved loading handler by eagerly loading template and providing nitro dev handler all the times

There might be some small regressions with this changes but i think overall better stability is worth to try and iterate faster. Checking locally little bit more to make sure there are not odd issues.

TODO: I am working to always initialize an internal listener + proxy. This patterns helps on HTTPs + Expose host stability for vite-node and internal calls.

@pi0 pi0 requested a review from danielroe September 7, 2023 14:13
@pi0 pi0 marked this pull request as draft September 7, 2023 14:15
@pi0 pi0 marked this pull request as ready for review September 7, 2023 15:43
@pi0 pi0 merged commit 2191619 into main Sep 7, 2023
2 checks passed
@pi0 pi0 deleted the fix/no-fork branch September 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant