fix: remove favicon handling (#2157)

nuxt · Jul 18, 2023 · 6f5e98e · 6f5e98e
1 parent 566e9d2
commit 6f5e98e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/playground/document-driven/nuxt.config.ts b/playground/document-driven/nuxt.config.ts
@@ -1,5 +1,16 @@
 export default defineNuxtConfig({
   extends: ['../shared'],
+  app: {
+    head: {
+      link: [
+        {
+          rel: 'icon',
+          type: 'image/ico',
+          href: '/favicon.ico'
+        }
+      ]
+    }
+  },
   content: {
     documentDriven: {
       globals: {

diff --git a/playground/document-driven/public/favicon.ico b/playground/document-driven/public/favicon.ico
diff --git a/src/runtime/plugins/documentDriven.ts b/src/runtime/plugins/documentDriven.ts
@@ -273,8 +273,6 @@ export default defineNuxtPlugin((nuxt) => {
 
   // Route middleware
   addRouteMiddleware(async (to, from) => {
-    // TODO: Remove this (https://github.com/nuxt/framework/pull/5274)
-    if (to.path.includes('favicon.ico')) { return }
     // Avoid calling on hash change
     if (process.client && !isClientDBEnabled && to.path === from.path) {
       if (!to.meta.layout) {