fix(headings): don't generate link if id is missing (#1893)

nuxt · Feb 7, 2023 · ee83de8 · ee83de8
1 parent 8d06196
commit ee83de8
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/src/runtime/components/Prose/ProseH1.vue b/src/runtime/components/Prose/ProseH1.vue
@@ -1,6 +1,6 @@
 <template>
   <h1 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 1
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)

diff --git a/src/runtime/components/Prose/ProseH2.vue b/src/runtime/components/Prose/ProseH2.vue
@@ -1,6 +1,6 @@
 <template>
   <h2 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 2
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)

diff --git a/src/runtime/components/Prose/ProseH3.vue b/src/runtime/components/Prose/ProseH3.vue
@@ -1,6 +1,6 @@
 <template>
   <h3 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 3
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)

diff --git a/src/runtime/components/Prose/ProseH4.vue b/src/runtime/components/Prose/ProseH4.vue
@@ -1,6 +1,6 @@
 <template>
   <h4 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 4
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)

diff --git a/src/runtime/components/Prose/ProseH5.vue b/src/runtime/components/Prose/ProseH5.vue
@@ -1,6 +1,6 @@
 <template>
   <h5 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 5
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)

diff --git a/src/runtime/components/Prose/ProseH6.vue b/src/runtime/components/Prose/ProseH6.vue
@@ -1,6 +1,6 @@
 <template>
   <h6 :id="id">
-    <a v-if="generate" :href="`#${id}`">
+    <a v-if="id && generate" :href="`#${id}`">
       <slot />
     </a>
     <slot v-else />
@@ -9,7 +9,7 @@
 
 <script setup lang="ts">
 import { useRuntimeConfig } from '#imports'
-defineProps<{ id: string }>()
+defineProps<{ id?: string }>()
 const heading = 6
 const { anchorLinks } = useRuntimeConfig().public.content
 const generate = anchorLinks?.depth >= heading && !anchorLinks?.exclude.includes(heading)