Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config for anchor link generation of headings #1564

Merged
merged 9 commits into from Oct 13, 2022
Merged

feat: config for anchor link generation of headings #1564

merged 9 commits into from Oct 13, 2022

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Sep 28, 2022

πŸ”— Linked issue

#1444

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Config can set if and for which headings to generate an anchor link
Resolves #1444

Default is set to generate anchor links for h2 to h4 like before

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

TODO

  • Move anchorLinks option to Markdown field
  • Test updated code
  • Update docs

@netlify
Copy link

netlify bot commented Sep 28, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 5d4bae0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/63481268fb7daf0008eae822
😎 Deploy Preview https://deploy-preview-1564--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nobkd nobkd changed the title feat: config for anchor link generation for headings feat: config for anchor link generation of headings Sep 29, 2022
@gitguardian
Copy link

gitguardian bot commented Oct 5, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Algolia Keys fc73fb1 docs/nuxt.config.ts View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

src/module.ts Outdated Show resolved Hide resolved
@nobkd nobkd marked this pull request as draft October 7, 2022 12:05
@farnabaz farnabaz marked this pull request as ready for review October 13, 2022 13:32
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@farnabaz farnabaz merged commit b455d0c into nuxt:main Oct 13, 2022
@nobkd nobkd deleted the feat/anchorLinkOptions branch October 13, 2022 14:32
@farnabaz farnabaz mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Prose Headings components should not render as links (bad HTML and too opinionated)
2 participants