Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(<ContentDoc>): render blink in SSG #1600

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

resolves #1583

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In SSG on client hydration useRoute().path contains additional slash at the end of path which cause cache miss in asyncData.
ContentDoc is responsible for fetching single content, so we can safely remove this trailing slash.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Oct 14, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 05762af
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/63495d4b16548a00083c797b
😎 Deploy Preview https://deploy-preview-1600--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz merged commit 2f410e8 into main Oct 14, 2022
@farnabaz farnabaz deleted the fix/content-doc-trailing-slash branch October 14, 2022 13:15
@farnabaz farnabaz mentioned this pull request Oct 19, 2022
farnabaz added a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document not found flash on load
1 participant