Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ContentRenderer): simplify conditions #1715

Merged
merged 3 commits into from Nov 30, 2022
Merged

refactor(ContentRenderer): simplify conditions #1715

merged 3 commits into from Nov 30, 2022

Conversation

huynl-96
Copy link
Contributor

🔗 Linked issue

NA

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Simplify conditional checks
  • Add an extra test outcome

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Nov 30, 2022 •
edited

✅ Deploy Preview for nuxt-content ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2aa21d7
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/638756bc9dea6a0008e0be42
😎 Deploy Preview https://deploy-preview-1715--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Atinux Atinux requested a review from farnabaz November 30, 2022 10:14
farnabaz
farnabaz approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

farnabaz
farnabaz requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huynl-96 Do you mind updating custom-api-base.test.ts to match basic.test.ts ?

@huynl-96
Copy link
Contributor Author

Forgot to re-run all the tests.
Thanks @farnabaz for pointing out.

Updated in 2aa21d7

@farnabaz farnabaz merged commit 5dfa181 into nuxt:main Nov 30, 2022
@huynl-96 huynl-96 deleted the refactor/content-renderer-conditions branch November 30, 2022 15:46
@farnabaz farnabaz mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huynl-96 @farnabaz