Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize highlighted text #1818

Merged
merged 1 commit into from Jan 11, 2023
Merged

fix: sanitize highlighted text #1818

merged 1 commit into from Jan 11, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously we were producing code like this:

<span class=\"ct-2c497b\"><</span>

which breaks the dom tree - or worse, renders the highlighted code directly as HTML elements.

Looking through the codebase it seems likely that this fix might need to be applied elsewhere too and it would be worth a quick look.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 11, 2023
@danielroe danielroe self-assigned this Jan 11, 2023
@netlify
Copy link

netlify bot commented Jan 11, 2023

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit c40d3da
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/63bec8a8492e8000090fc814
😎 Deploy Preview https://deploy-preview-1818--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ‘

@farnabaz farnabaz merged commit bb33b58 into main Jan 11, 2023
@farnabaz farnabaz deleted the fix/sanitize-text branch January 11, 2023 15:39
@farnabaz farnabaz mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants