Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce component-resolver transformer #1907

Merged
merged 4 commits into from Feb 20, 2023

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Introducing new transformer for client side usage to pre import dynamic components that used in markdown during parse.

Background:
Using dynamic component in Markdown, causes a blink in client side rendering. This behavior exists because Suspense shows an empty fallback while MarkdownRendere tries to load dynamic components. With preloading components in parse time, we can avoid this blink and layout should and force Suspense to not show the fallback state.

Additionally, with this feature, we will be able to load non-global component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 16, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Feb 16, 2023

❌ Deploy Preview for nuxt-content failed.

Name Link
πŸ”¨ Latest commit
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/63efb1fdd891f600500989e0

@farnabaz farnabaz requested a review from Atinux February 16, 2023 15:55
@farnabaz farnabaz marked this pull request as ready for review February 20, 2023 14:25
@farnabaz farnabaz merged commit 3f6efe8 into main Feb 20, 2023
@farnabaz farnabaz deleted the feat/component-resolver-transformer branch February 20, 2023 14:25
@farnabaz farnabaz mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants