Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add github in sources #1946

Merged
merged 3 commits into from Mar 8, 2023
Merged

docs: add github in sources #1946

merged 3 commits into from Mar 8, 2023

Conversation

Barbapapazes
Copy link
Contributor

@Barbapapazes Barbapapazes commented Mar 5, 2023

πŸ”— Linked issue

fix #1945

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Maybe a full page to explain how sources works could make this part of the plugin more understandable πŸ€·β€β™‚οΈ

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 5, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@nuxt-studio
Copy link

nuxt-studio bot commented Mar 5, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview b2de53c

@netlify
Copy link

netlify bot commented Mar 5, 2023

βœ… Deploy Preview for nuxt-content canceled.

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit b2de53c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64061f1d8c7e1400081fbbd3

@nuxt-studio
Copy link

nuxt-studio bot commented Mar 5, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview 6f7dae8

@Barbapapazes Barbapapazes changed the title Docs sources docs: add github in sources Mar 5, 2023
@farnabaz
Copy link
Member

farnabaz commented Mar 6, 2023

Do you mind cleaning the PR and just keep docs changes?

@Barbapapazes
Copy link
Contributor Author

Do you mind cleaning the PR and just keep docs changes?

Yes, that's clearly an issue. Will fix this asap.

@Barbapapazes
Copy link
Contributor Author

Do you mind cleaning the PR and just keep docs changes?

@farnabaz I remove the unwanted code.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farnabaz farnabaz merged commit 06335ab into nuxt:main Mar 8, 2023
@farnabaz farnabaz mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs about usage about using github from sources configuration
2 participants