Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module): close dev server on nitro close #1952

Merged
merged 1 commit into from Mar 8, 2023
Merged

fix(module): close dev server on nitro close #1952

merged 1 commit into from Mar 8, 2023

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Mar 8, 2023

🔗 Linked issue

resolves #1935

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 8, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited

✅ Deploy Preview for nuxt-content ready!

Name Link
🔨 Latest commit b433d4b
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64088670b8915b0008916926
😎 Deploy Preview https://deploy-preview-1952--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz merged commit ee434ef into main Mar 8, 2023
@farnabaz farnabaz deleted the fix/ws-close-server branch March 8, 2023 13:04
@farnabaz farnabaz mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full nuxt restart doesn't close websocket server
1 participant
@farnabaz