Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set property instead of name for og metadata #1981

Merged
merged 1 commit into from Mar 28, 2023
Merged

fix: set property instead of name for og metadata #1981

merged 1 commit into from Mar 28, 2023

Conversation

tmlmt
Copy link
Contributor

@tmlmt tmlmt commented Mar 28, 2023 •
edited by Atinux

🔗 Linked issue

Resolves #1980

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Replaced name attribute by property for og meta tags
Resolves #1980

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 28, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited

✅ Deploy Preview for nuxt-content canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c51f699
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/642238c6b57d1f0008c9e313

@Atinux Atinux requested a review from farnabaz March 28, 2023 07:37
farnabaz
farnabaz approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@farnabaz farnabaz merged commit 4dd4cb9 into nuxt:main Mar 28, 2023
6 checks passed
@farnabaz farnabaz mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atinux Atinux Atinux approved these changes

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

og meta tags are set with name instead of property
3 participants
@tmlmt @Atinux @farnabaz