Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): use sessionStorage to keep token #2020

Merged
merged 4 commits into from Apr 18, 2023

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Safari blocks storing/accessing cookies inside iframe. (see) With this PR, module supports session storage as secondary storage to look for preview token.
  • <ContentRendererMarkdown> adds data-content-id attribute to its root element

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 17, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Apr 17, 2023

βœ… Deploy Preview for nuxt-content canceled.

Name Link
πŸ”¨ Latest commit 1789556
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/643e69e1a020540008abe31a

@farnabaz farnabaz merged commit 5599f27 into main Apr 18, 2023
7 checks passed
@farnabaz farnabaz deleted the feat/preview-in-session-storage branch April 18, 2023 10:06
@farnabaz farnabaz mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant