Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace crlf line endings with lf #2120

Merged
merged 2 commits into from Jun 27, 2023
Merged

fix: replace crlf line endings with lf #2120

merged 2 commits into from Jun 27, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Jun 24, 2023

πŸ”— Linked issue

resolves #2000

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Replaces CRLF (or CR) line endings with LF to prevent a vue hydration mismatch
\r\n || \r => \n

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 24, 2023

βœ… Deploy Preview for nuxt-content canceled.

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 5160314
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/649788c76ef8a40008572c40

@nobkd
Copy link
Contributor Author

nobkd commented Jun 25, 2023

Seems like content is of type object in a test with the file test/fixtures/basic/content/_partial/simple-json.json

Maybe the types hints of the functions should be updated? Or what is that test for?

@farnabaz
Copy link
Member

Thanks @nobkd
Indeed, we need to update types. unstorage's return value is not just string, it is null | string | number | boolean | object

This looks good to me, merging this and lets updates types in another PR

@farnabaz farnabaz merged commit 2ac3616 into nuxt:main Jun 27, 2023
7 checks passed
@nobkd nobkd deleted the fix/line-break-hydration-mismatch branch June 27, 2023 12:37
@nobkd nobkd mentioned this pull request Jul 3, 2023
7 tasks
@farnabaz farnabaz mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration mismatch because of different "newline"
2 participants