feat: allow to disable content head #2142
Conversation
✅ Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Live Preview ready!
|
✅ Live Preview ready!
|
| @@ -94,12 +97,12 @@ export default defineComponent({ | |||
| // Default slot | |||
| default: slots?.default | |||
| ? ({ data, refresh, isPartial }: any) => { | |||
| if (head) { useContentHead(data) } | |||
| if (head && enableContentHead) { useContentHead(data) } | |||
There was a problem hiding this comment.
I think it is a better approach if we use enableContentHead as default value head props and let users overwrite it in special cases if they want to.
There was a problem hiding this comment.
I don't understand this comment. Could you explain we use enableContentHead as default value head props.
There was a problem hiding this comment.
This component accepts a head props with true as default, we can set the default to undefined then assing enableContentHead to it if it's undefined
maybe this snippet describes it better
const shouldInjectContentHead = props.head === undefined ? enableContentHead : props.head
if (shouldInjectContentHead) { useContentHead(data) }There was a problem hiding this comment.
Okkk, I understand. Will update the PR.
src/module.ts
Outdated
| @@ -746,6 +754,8 @@ interface ModulePublicRuntimeConfig { | |||
|
|
|||
| navigation: ModuleOptions['navigation'] | |||
|
|
|||
| enableContentHead: ModuleOptions['enableContentHead'] | |||
There was a problem hiding this comment.
Maybe contentHeadMeta or contentMetaTags, instead of enableContentHead. WDYT?
There was a problem hiding this comment.
still as a boolean?
There was a problem hiding this comment.
Yes as a boolean, or maybe simpler contentHead
There was a problem hiding this comment.
Like documentDriven option, users can set it to false
Co-authored-by: nobkd <44443899+nobkd@users.noreply.github.com>
|
Thanks ❤️ |
🔗 Linked issue
fix #2141
❓ Type of change
📚 Description
I added a flag to disable usage of
useContentHeadin the module for advanced users.📝 Checklist