Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning for NuxtPage in app.vue (2.get-started.md) #2244

Merged
merged 2 commits into from Aug 24, 2023

Conversation

mdartic
Copy link
Contributor

@mdartic mdartic commented Aug 23, 2023

πŸ”— Linked issue

None

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When I try Content for the first time, I already instantiate a nuxt app with the default template.

My app.vue was looking like that :

<template>
  <div>
    <NuxtWelcome />
  </div>
</template>

After executing what was written in the getting started, my nuxt app wasn't displaying my content/index.md page.
Instead, I was still seeing the <NuxtWelcome /> component.

I'm not sure it's useful to create an issue for this, so I create a PR directly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link

nuxt-studio bot commented Aug 23, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview 967fcea

@nuxt-studio
Copy link

nuxt-studio bot commented Aug 23, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview 10d2736

@netlify
Copy link

netlify bot commented Aug 23, 2023

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 967fcea
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64e745b4dda1870007c568af
😎 Deploy Preview https://deploy-preview-2244--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@farnabaz farnabaz merged commit b32562e into nuxt:main Aug 24, 2023
6 of 7 checks passed
@farnabaz farnabaz mentioned this pull request Aug 29, 2023
@mdartic mdartic deleted the mdartic-patch-1 branch August 30, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants