fix(module): remove deprecated resolveModule
#2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-content canceled.
|
pi0
reviewed
Sep 8, 2023
| @@ -307,7 +306,7 @@ export default defineNuxtModule<ModuleOptions>({ | |||
| }, | |||
| async setup (options, nuxt) { | |||
| const { resolve } = createResolver(import.meta.url) | |||
| const resolveRuntimeModule = (path: string) => resolveModule(path, { paths: resolve('./runtime') }) | |||
| const resolveRuntimeModule = (path: string) => resolve('./runtime', path) | |||
There was a problem hiding this comment.
Not that resolve just joint paths. It doesn't check extensions and they are not alternatives. You might want to use resolver.resolePath but have to try
There was a problem hiding this comment.
AFAIK almost in every case of our usages Nuxt takes care of the extension matching and module works fine with resolve function
Am I wrong about extension matching?
There was a problem hiding this comment.
If you want to rely on that (and it works with published module) surely!
There was a problem hiding this comment.
I've tested the build in a real project and it's fine. Will merge and check on edge channel too.
Thanks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist