Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix page overflow #2332

Merged
merged 1 commit into from Sep 21, 2023
Merged

docs: fix page overflow #2332

merged 1 commit into from Sep 21, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Sep 21, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The new docs (#2310) have a gradient on the home page which is positioned absolute and overflows to the right of the page, as it takes 100% width.

(Checked with Firefox 117.0.1 and Chromium 116.0.5845.187 on Linux)

Screenshot 2023-09-21 at 21-10-19 Nuxt Content made easy for Vue Developers

Possible changes are

  • setting the parent element to hide overflow(-x)
    -> gradient shifted slightly right
  • or to add a left: 0 to the absolutely positioned element
    -> gradient centered

I decided to use left: 0 which looks like this:

Screenshot 2023-09-21 at 21-11-01 Nuxt Content made easy for Vue Developers

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Atinux Atinux merged commit 241771d into nuxt:main Sep 21, 2023
2 checks passed
@nobkd nobkd deleted the patch-1 branch September 21, 2023 19:37
@farnabaz farnabaz mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants