Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add regex to match ContentSlot in Pug templates #2344

Merged
merged 2 commits into from Sep 26, 2023
Merged

fix: add regex to match ContentSlot in Pug templates #2344

merged 2 commits into from Sep 26, 2023

Conversation

jbmolle
Copy link
Contributor

@jbmolle jbmolle commented Sep 26, 2023

🔗 Linked issue

#2343

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • [ x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added a regex line to match ContentSlot in Pug template. Resolves #2343

📝 Checklist

  • [x ] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@farnabaz
Copy link
Member

@jbmolle Do you mind fixing lint issues?

@jbmolle
Copy link
Contributor Author

jbmolle commented Sep 26, 2023

Should be correctly linted now

farnabaz
farnabaz approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ❤️

@farnabaz farnabaz merged commit 6163210 into nuxt:main Sep 26, 2023
2 checks passed
@farnabaz farnabaz mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContentSlot gives warning when using Pug template
2 participants
@jbmolle @farnabaz