Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect naming & link path in Component/Prose #2513

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

charlie0228
Copy link
Contributor

@charlie0228 charlie0228 commented Jan 19, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

According to https://github.com/nuxt/content/blob/main/src/module.ts#L343
We replace ProseCode.vue define into ProseCodeInline.vue
And using ProsePre.vue to wrap ProseCode.vue

So, if i want to use custom prose component, I have to named ProsePre.vue in order to replace the code block in .md

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Jan 19, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Content Edit on Studio β†—οΈŽ View Live Preview bcf63ca

@charlie0228
Copy link
Contributor Author

I am not sure about this PR #2187.
Is there should fix together?

@charlie0228 charlie0228 changed the title docs: dix incorrect link path in Component/Prose docs: fix incorrect link path in Component/Prose Jan 19, 2024
@charlie0228 charlie0228 changed the title docs: fix incorrect link path in Component/Prose docs: fix incorrect naming & link path in Component/Prose Jan 22, 2024
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@farnabaz farnabaz merged commit 3195944 into nuxt:main Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants