perf(content-list): cache contents list during generation and per-request #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atinux
reviewed
Jan 26, 2024
src/runtime/server/storage.ts
Outdated
| @@ -38,6 +38,7 @@ export const cacheStorage: Storage = prefixStorage(useStorage(), 'cache:content' | |||
| export const cacheParsedStorage: Storage = prefixStorage(useStorage(), 'cache:content:parsed') | |||
|
|
|||
| const isProduction = process.env.NODE_ENV === 'production' | |||
| const isPrerendering = process.argv?.includes('generate') | |||
There was a problem hiding this comment.
I think we should use import.meta.prerender
Deploying with ย
|
| Latest commit: |
732edc1
|
| Status: | ย โ ย Deploy successful! |
| Preview URL: | https://77e5d7bd.nuxt-content-1il.pages.dev |
| Branch Preview URL: | https://perf-cache-contents-list.nuxt-content-1il.pages.dev |
|
may i ask when will this be released |
|
@manlm you can use the edge channel to use it today: https://content.nuxt.com/get-started/edge-channel Release should be next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Linked issue
resolves #2449
โ Type of change
๐ Description
The bottleneck in the pre-rendering phase is getting contents list from file system. By caching the list in the pre-render process, the generation time will drop significantly.
This change reduce the generation time in Content docs from 15s to 5s on my machine
๐ Checklist