fix: optimise nested dependencies #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
slugify with nested config
Deploying with
|
| Latest commit: |
eade3cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2692941c.nuxt-content-1il.pages.dev |
| Branch Preview URL: | https://fix-optimise-unhoisted.nuxt-content-1il.pages.dev |
farnabaz
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #2381 together with nuxt-modules/mdc#160
❓ Type of change
📚 Description
Vite requires dependencies that are optimised to be installed, but
slugifywon't be directly installed by users. So we can indicate to vite to resolve the dependency from within another dependency that is installed, in this case@nuxt/content...We also have to modify the list for deps injected by
@nuxtjs/mdcas that module won't be directly installed either.📝 Checklist