fix(terminals): badge number (#279)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
nuxt · Jun 18, 2023 · 7f922df · 7f922df
1 parent 980ad3c
commit 7f922df
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/packages/devtools-kit/src/_types/custom-tabs.ts b/packages/devtools-kit/src/_types/custom-tabs.ts
@@ -121,7 +121,7 @@ export interface ModuleBuiltinTab {
   path?: string
   category?: TabCategory
   show?: () => MaybeRefOrGetter<any>
-  badge?: () => number | string | undefined
+  badge?: () => MaybeRefOrGetter<number | string | undefined>
   onClick?: () => void
 }
 

diff --git a/packages/devtools/client/components/SideNavItem.vue b/packages/devtools/client/components/SideNavItem.vue
@@ -31,7 +31,7 @@ const isActive = computed(() => route.path.startsWith(tabPath.value))
         v-if="badge" absolute bottom-0 right-0 h-4 w-4 rounded-full text-9px text-white flex="~ items-center justify-center"
         :class="isActive ? 'bg-primary' : 'bg-gray'"
       >
-        <span translate-y-0.5px>{{ badge }}</span>
+        <span translate-y-0.5px>{{ toValue(badge) }}</span>
       </div>
     </NuxtLink>
     <template #popper>

diff --git a/packages/devtools/client/meta.d.ts b/packages/devtools/client/meta.d.ts
@@ -1,4 +1,5 @@
-import { TabCategory } from "../src/types"
+import { MaybeRefOrGetter } from 'vue'
+import { TabCategory } from '../src/types'
 
 declare module '#app' {
   interface PageMeta {
@@ -7,7 +8,7 @@ declare module '#app' {
     order?: number
     category?: TabCategory
     show?: () => any
-    badge?: () => string | number | undefined
+    badge?: () => MaybeRefOrGetter<string | number | undefined>
   }
 }
 

diff --git a/packages/devtools/client/pages/modules/terminals.vue b/packages/devtools/client/pages/modules/terminals.vue
@@ -16,6 +16,6 @@ definePageMeta({
 
 <template>
   <AuthRequiredPanel>
-    <TerminalsPage />
+    <TerminalPage />
   </AuthRequiredPanel>
 </template>