Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(pkg): remove vue 3 from peerDependencies #1382

Merged
merged 1 commit into from
Oct 22, 2021
Merged

fix(pkg): remove vue 3 from peerDependencies #1382

merged 1 commit into from
Oct 22, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 22, 2021

πŸ”— Linked issue

nuxt/bridge#292

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

npm >= 7 install peerDependencies unlike older versions of node and yarn. This causes issues for bridge users as they install nitro as a sub dependency.

Also moving vue from peerDepenencies to dependencies of nuxt3 as we don't ask users to install it anyway

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe October 22, 2021 22:10
@netlify
Copy link

netlify bot commented Oct 22, 2021

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: d162a47

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61733933cfacd5000856f8d5

@danielroe
Copy link
Member

I think this should be good πŸ‘ We'll see as we work on nuxt/nuxt#11823 whether this pokes its head up again, but I think the vue3 nitro dependency is really a dependency of the built file rather than nitro itself, so πŸ€·β€β™‚οΈ

@pi0
Copy link
Member Author

pi0 commented Oct 22, 2021

Regarding vue@3, we are adding nuxt3/node_modules to modulesDir (https://github.com/nuxt/framework/blob/main/packages/nuxt3/src/core/nuxt.ts#L73) if nitro is not using it is a bug :D

@pi0 pi0 merged commit 06e9c7e into main Oct 22, 2021
@pi0 pi0 deleted the fix/nitro-vue branch October 22, 2021 22:25
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants