This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxi, kit): import individual semver function #1598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
closes nuxt/nuxt#12839
closes nuxt/nuxt#12673
β Type of change
π Description
This is an issue with rollup bundling semver into the
nuxi
bundle. The bundled file is (abbreviated):In other words, we have a bit of mis-ordering of the file. So when
semver.satisfies
hits an error, becauseComparator$3
isn't an object, it swallows it and returnsfalse
.See npm/node-semver#381
This PR implements the workaround described in this comment - which also, as a plus, decreases our bundle size.
π Checklist