This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): assign different hmr port for each instance #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: danielroe <danielroe@users.noreply.github.com>
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 1313921 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6205200acbc79d0007f212aa |
antfu
changed the title
pi0
reviewed
Feb 10, 2022
| const hmrPortDefault = 24678 // Vite's default HMR port | ||
| const hmrPort = await getPort({ | ||
| port: hmrPortDefault, | ||
| ports: Array.from({ length: 20 }, (_, i) => hmrPortDefault + 1 + i) |
There was a problem hiding this comment.
Any reason not just use a random port?
There was a problem hiding this comment.
No, I am just not sure about how random works. Could change it to random if you want to
pi0
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fix nuxt/nuxt#13325, Fix partially nuxt/nuxt#11956
❓ Type of change
📚 Description
Thanks a lot for @danielroe's help!
The root cause of HMR breakage is because in middleware mode of Vite, the HMR port is fixed to 24678. Which means when you have multiple Vite/Nuxt instances running, it causes the later server to connect to the wrong Websocket instance, making the HMR fail to trigger. This PR makes the port dynamic with the currently available ports.
📝 Checklist