Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt3): return error page on blocked initial navigation #3201

Merged
merged 7 commits into from Feb 14, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13380

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a hotfix for nuxt/nuxt#13380, pending reworking with result of https://github.com/nuxt/framework/discussions/559. It returns an (empty) 401 response.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Feb 11, 2022
@danielroe danielroe requested a review from pi0 February 11, 2022 16:04
@danielroe danielroe self-assigned this Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

βœ”οΈ Deploy Preview for nuxt3-docs canceled.

πŸ”¨ Explore the source changes: 63e8109

πŸ” Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/620a381c044243000830fb70

packages/nuxt3/src/pages/runtime/router.ts Outdated Show resolved Hide resolved
packages/nuxt3/src/pages/runtime/router.ts Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(nuxt3): return 401 code on blocked initial navigation (hotfix) fix(nuxt3): return error page on blocked initial navigation Feb 12, 2022
@danielroe danielroe requested a review from pi0 February 14, 2022 10:51
packages/nuxt3/src/pages/runtime/router.ts Outdated Show resolved Hide resolved
packages/nuxt3/src/pages/runtime/router.ts Outdated Show resolved Hide resolved
packages/nuxt3/src/pages/runtime/router.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 3589a2d into main Feb 14, 2022
@pi0 pi0 deleted the fix/hotfix-router branch February 14, 2022 14:18
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pages with abortNavigation hang on initial load in SSR
2 participants