Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): update regex to handle new vite output format #4014

Merged
merged 1 commit into from Apr 1, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13589

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR updates the regex to avoid duplicate hits: see Rich-Harris/magic-string#208 (comment).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Apr 1, 2022
@danielroe danielroe requested a review from pi0 April 1, 2022 09:13
@danielroe danielroe self-assigned this Apr 1, 2022
@netlify
Copy link

netlify bot commented Apr 1, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit ccd751c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6246c256a7a1d50008db912f

@pi0 pi0 requested a review from antfu April 1, 2022 10:13
@pi0 pi0 merged commit 51f3bbf into main Apr 1, 2022
@pi0 pi0 deleted the fix/split-chunks branch April 1, 2022 10:15
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot split a chunk that has already been edited
2 participants