Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat: allow disabling sourcemap generation #4509

Merged
merged 6 commits into from Apr 22, 2022
Merged

feat: allow disabling sourcemap generation #4509

merged 6 commits into from Apr 22, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 21, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR disables sourcemap generation for our various transform plugins when building. (I would also be open to adding a build.sourceMap option that allows configuring sourcemap generation.)

I've seen one or two reports of memory issues when building, and have previously resolved this with turning off magic string sourcemaps. For context:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Apr 21, 2022
@danielroe danielroe requested review from pi0 and antfu April 21, 2022 14:57
@danielroe danielroe self-assigned this Apr 21, 2022
@netlify
Copy link

netlify bot commented Apr 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 79b2733
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6262c86e5071ad0009fb013a

@pi0
Copy link
Member

pi0 commented Apr 22, 2022

Do you have any context of the source map memory leak issue? It can happen when enabling development too and we can't just mask the issue this is a nice feature for production build too.

@pi0 pi0 changed the title perf: disable sourcemap generation when building perf: allow disabling sourcemap generation Apr 22, 2022
@pi0 pi0 changed the title perf: allow disabling sourcemap generation feat: allow disabling sourcemap generation Apr 22, 2022
@pi0 pi0 merged commit 650d12f into main Apr 22, 2022
@pi0 pi0 deleted the perf/sourcemap-build branch April 22, 2022 15:35
@pi0 pi0 mentioned this pull request May 2, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants