This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(nuxi): show base url in terminal message #5337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pi0
reviewed
Jun 8, 2022
Considering upstream gets merged, what happens if user is setting base URL directly in |
(upstream PR is released. still i'm worried about first banner lacking base) |
Are you ok with that we disable |
Sure we can add show banner to the line after |
@antfu Any update on this? |
Shall be ready now. |
pi0
changed the title
feat: show baseUrl in terminal
fix(nuxi): show base url in terminal message
Jul 12, 2022
pi0
approved these changes
Jul 12, 2022
pi0
approved these changes
Jul 12, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Requires unjs/listhen#28
β Type of change
π Description
When we configure
app.baseURL
, the terminal still shows the root URL likehttp://localhost:3000/
.This PR requires upstream unjs/listhen#28
π Checklist