Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): show base url in terminal message #5337

Merged
merged 6 commits into from
Jul 12, 2022
Merged

fix(nuxi): show base url in terminal message #5337

merged 6 commits into from
Jul 12, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 7, 2022

πŸ”— Linked issue

Requires unjs/listhen#28

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When we configure app.baseURL, the terminal still shows the root URL like http://localhost:3000/.

This PR requires upstream unjs/listhen#28

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jun 7, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 10981e1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62cd618d7355cf0008b32ee0
😎 Deploy Preview https://deploy-preview-5337--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Member

pi0 commented Jun 9, 2022

Considering upstream gets merged, what happens if user is setting base URL directly in nuxt.config? I guess first banner would show without and then subsequent reloads add base with override of showURL?

@pi0
Copy link
Member

pi0 commented Jun 15, 2022

(upstream PR is released. still i'm worried about first banner lacking base)

@antfu
Copy link
Member Author

antfu commented Jun 15, 2022

Are you ok with that we disable showUrl option in listen and call it manually after the config resolve?

@pi0
Copy link
Member

pi0 commented Jun 15, 2022

Sure we can add show banner to the line after loadNuxt! It makes startup feeling little bit slower but solves this particular issue...

@pi0
Copy link
Member

pi0 commented Jun 22, 2022

@antfu Any update on this?

@antfu
Copy link
Member Author

antfu commented Jul 12, 2022

Shall be ready now.

@pi0 pi0 changed the title feat: show baseUrl in terminal fix(nuxi): show base url in terminal message Jul 12, 2022
@pi0 pi0 merged commit 100dfa6 into main Jul 12, 2022
@pi0 pi0 deleted the fix/show-base-url branch July 12, 2022 12:12
@pi0 pi0 mentioned this pull request Jul 12, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants