Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

chore: use vue exports of compiler-sfc and server-renderer #575

Closed
wants to merge 1 commit into from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 24, 2021

📚 Description

For vue 3.2.13+, we can import directly from vue/server-renderer and vue/compiler-sfc rather than adding to our own dependencies: vue docs

This PR is a quick removal of our dependencies for the purpose of testing.

📝 Checklist

  • Confirm no issues with pnp see plug and play support nuxt#11823
  • Confirm we're not now accidentally inlining @vue/compiler-sfc and @vue/server-renderer in the affected packages
  • test with external package

@danielroe danielroe added the wip label Sep 24, 2021
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4eae5e
Status: ✅  Deploy successful!
Preview URL: https://54640a2e.framework-1rm.pages.dev

View logs

@pi0
Copy link
Member

pi0 commented Sep 24, 2021

Confirm we're not now accidentally inlining @vue/compiler-sfc and @vue/server-renderer in the affected packages

Can we try to use rollup aliases to ensure it won't happen by accident in one of sub-deps?

@pi0
Copy link
Member

pi0 commented Sep 25, 2021

@danielroe Any updates on this? I think we can postpone checklist if other things already working (alias would be nice although)

@danielroe
Copy link
Member Author

Rollup plugin seems simple but not sure alias will work, though I will try it. Issue is that vue/server-renderer simply re-exports @vue/server-renderer so we don't want to end up with an unresolvable dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants