This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): fallback to static error page on server error #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
antfu
commented
Aug 17, 2022
|
Trying locally, the production build errors makes an infinity loop. Investigating...
|
pi0
reviewed
Aug 17, 2022
| @@ -1,7 +1,6 @@ | |||
| import { withQuery } from 'ufo' | |||
| import type { NitroErrorHandler } from 'nitropack' | |||
| import type { H3Error } from 'h3' | |||
| import { importModule } from '@nuxt/kit' | |||
There was a problem hiding this comment.
@danielroe Do you have any idea why this wasn't caught by import protection?
pi0
approved these changes
Aug 17, 2022
pi0
force-pushed
the
feat/static-error-page
branch
from
5638bfc
to
4147ee6
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Part of #6683
❓ Type of change
📚 Description
When there is a server error, the
/__nuxt_errormight also fail to render, we fallback to use static HTML render in this case.📝 Checklist