Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt): remove unused meta:register hook #7130

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

https://github.com/nuxt/framework/discussions/7125

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This removes a hook that was only used for Nuxt Bridge integration: #664.

It might be useful to reconsider adding back some kind of hook implementation in future but for now it's unused and can be removed.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 1, 2022
@danielroe danielroe requested a review from pi0 September 1, 2022 08:43
@danielroe danielroe self-assigned this Sep 1, 2022
@netlify
Copy link

netlify bot commented Sep 1, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 1f4ed27
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6310709d9d480900092dc47d
😎 Deploy Preview https://deploy-preview-7130--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title fix(nuxt): remove unused meta:register hook refactor(nuxt): remove unused meta:register hook Sep 1, 2022
@pi0 pi0 merged commit 6fbbf8c into main Sep 1, 2022
@pi0 pi0 deleted the fix/stale-hook branch September 1, 2022 09:08
@pi0
Copy link
Member

pi0 commented Sep 1, 2022

Thanks.

@pi0 pi0 mentioned this pull request Sep 1, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants