Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat: allow extending with theme config #7131

Merged
merged 3 commits into from
Sep 1, 2022
Merged

feat: allow extending with theme config #7131

merged 3 commits into from
Sep 1, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 1, 2022

πŸ”— Linked issue

Resolves nuxt/nuxt#14329

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR allows extending nuxt app using theme alias config. Typing for theme config in nuxt.config is intentionally set to string while string[] is also possible by c12. This is to guide the correct usage of extends vs theme. Extends from theme has highest layer priority by default too.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 1, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 1bda1dd
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63107ddace31fa0009be221a

@pi0 pi0 changed the title feat(kit): allow extending with theme config feat: allow extending with theme config Sep 1, 2022
@pi0 pi0 merged commit 68d12b4 into main Sep 1, 2022
@pi0 pi0 deleted the feat/extends-theme-alias branch September 1, 2022 10:05
@pi0 pi0 mentioned this pull request Sep 1, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config alias theme to extends
2 participants