Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): allow abortMiddleware to receive a nuxt error or error options #7335

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13993

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is the last piece in the linked issue. It means we can respect a nuxt error thrown in middleware, namely set our own status code/message.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Sep 7, 2022
@danielroe danielroe requested a review from pi0 September 7, 2022 21:40
@danielroe danielroe self-assigned this Sep 7, 2022
@netlify
Copy link

netlify bot commented Sep 7, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit fe40ea4
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63190fc33de386000831fcb3

@pi0 pi0 changed the title feat(nuxt): allow abortMiddleware to receive a nuxt error or error options fix(nuxt): allow abortMiddleware to receive a nuxt error or error options Sep 8, 2022
@pi0 pi0 merged commit 9c3bef4 into main Sep 8, 2022
@pi0 pi0 deleted the feat/abort-mw branch September 8, 2022 08:52
This was referenced Sep 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route middleware abortNavigation/navigateTo missing options
2 participants